Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

[no-reply@xxxxxxxxxxx]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1520530757-4477-1-git-send-email-ian.jackson@xxxxxxxxxxxxx
Subject: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               
patchew/1520530757-4477-1-git-send-email-ian.jackson@xxxxxxxxxxxxx -> 
patchew/1520530757-4477-1-git-send-email-ian.jackson@xxxxxxxxxxxxx
Switched to a new branch 'test'
4c25442ead scripts/get_maintainer.pl: Print proper error message for missing 
$file
adccb2d1cf xen: Expect xenstore write to fail when restricted
d7215f329e xen: Use newly added dmops for mapping VGA memory
f7f185a6a1 configure: do_compiler: Dump some extra info under bash
75567778ca os-posix: Provide new -runas <uid>:<gid> facility
af7d485861 xen: destroy_hvm_domain: Try xendevicemodel_shutdown
334ccae63f xen: move xc_interface compatibility fallback further up the file
3a51d35517 xen: destroy_hvm_domain: Move reason into a variable
f40125a544 xen: defer call to xen_restrict until just before os_setup_post
7a4e636857 xen: restrict: use xentoolcore_restrict_all
259eb4de38 xen: link against xentoolcore

=== OUTPUT BEGIN ===
Checking PATCH 1/11: xen: link against xentoolcore...
Checking PATCH 2/11: xen: restrict: use xentoolcore_restrict_all...
Checking PATCH 3/11: xen: defer call to xen_restrict until just before 
os_setup_post...
Checking PATCH 4/11: xen: destroy_hvm_domain: Move reason into a variable...
Checking PATCH 5/11: xen: move xc_interface compatibility fallback further up 
the file...
Checking PATCH 6/11: xen: destroy_hvm_domain: Try xendevicemodel_shutdown...
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: hw/i386/xen/xen-hvm.c:1398:
+        if (errno != ENOTTY /* old Xen */)
[...]

total: 1 errors, 0 warnings, 33 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/11: os-posix: Provide new -runas <uid>:<gid> facility...
Checking PATCH 8/11: configure: do_compiler: Dump some extra info under bash...
Checking PATCH 9/11: xen: Use newly added dmops for mapping VGA memory...
ERROR: Error messages should not contain newlines
#90: FILE: hw/i386/xen/xen-hvm.c:406:
+                     " to GFN %"PRI_xen_pfn" failed: %s\n",

ERROR: Error messages should not contain newlines
#102: FILE: hw/i386/xen/xen-hvm.c:417:
+        error_report("pin_memory_cacheattr failed: %s\n", strerror(errno));

ERROR: Error messages should not contain newlines
#134: FILE: hw/i386/xen/xen-hvm.c:450:
+                     " to GFN %"PRI_xen_pfn" failed: %s\n",

ERROR: spaces required around that '*' (ctx:WxV)
#152: FILE: include/hw/xen/xen_common.h:95:
+    xendevicemodel_handle *dmod, domid_t domid, uint32_t size, uint64_t 
src_gfn,
                           ^

ERROR: braces {} are necessary for all arms of this statement
#164: FILE: include/hw/xen/xen_common.h:107:
+        if (rc)
[...]

ERROR: spaces required around that '*' (ctx:WxV)
#172: FILE: include/hw/xen/xen_common.h:115:
+    xendevicemodel_handle *dmod, domid_t domid, uint64_t start, uint64_t end,
                           ^

total: 6 errors, 0 warnings, 138 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/11: xen: Expect xenstore write to fail when restricted...
Checking PATCH 11/11: scripts/get_maintainer.pl: Print proper error message for 
missing $file...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel