Re: [Xen-devel] [PATCH 3/3] tests/x86emul: Improve the utility of verbose mode

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.03.18 at 21:24, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/tools/tests/x86_emulator/test_x86_emulator.c
> +++ b/tools/tests/x86_emulator/test_x86_emulator.c
> @@ -16,6 +16,53 @@
>  #include "xop.h"
>  
>  #define verbose false /* Switch to true for far more logging. */
> +#define fn_width (int)(sizeof("cmpxchg") - 1)

Strictly speaking this needs another pair of parentheses. But you
can avoid this by simply moving the cast into the existing ones.

> +static const char *seg_to_str(enum x86_segment seg)
> +{
> +    switch ( seg )
> +    {
> +#define CASE(x) case x86_seg_ ## x: return # x
> +        CASE(es);

Here and also in the other helper the indentation of the CASE()es
is one level too deep.

With these addressed
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel