Re: [Xen-devel] [PATCH 1/3] tests/x86emul: Helpers to save and restore FPU state

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.03.18 at 21:24, <andrew.cooper3@xxxxxxxxxx> wrote:
> +void emul_save_fpu_state(void)
> +{
> +    if ( use_xsave )
> +        asm volatile ( "xsave" __OS " %[ptr]"
> +                       : [ptr] "=m" (fpu_save_area)
> +                       : "a" (~0ull), "d" (~0ull) );

Wait, this doesn't build as 32-bit binary. Needs to be ~0ul, and
__OS also can't be used here.

> +    else
> +        asm volatile ( "fxsave %0" : "=m" (fpu_save_area) );

Whereas if you want something like __OS above, you'd want the
same here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel