Re: [Xen-devel] [PATCH v6 7/9] x86/mm: provide put_page_type_ptpg{, _preemptible}

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.02.18 at 21:04, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -2736,8 +2744,8 @@ int put_old_guest_table(struct vcpu *v)
>      if ( !v->arch.old_guest_table )
>          return 0;
>  
> -    switch ( rc = _put_page_type(v->arch.old_guest_table, true,
> -                                 v->arch.old_guest_ptpg) )
> +    switch ( rc = put_page_type_ptpg_preemptible(v->arch.old_guest_table,
> +                                                 v->arch.old_guest_ptpg) )

Having looked briefly at patch 8, it looks like this - PV only
afaict - function is the only thing not being moved there, and
hence the only reason to have the helpers you introduce here.
Part of your problem is that a fair part of e.g. _put_page_type()
is PV-only, and hence would perhaps want moving or #ifdef-ing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel