Re: [Xen-devel] [PATCH v4 08/16] xen/mm: Drop the parameter mfn from populate_pt_range

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

On 03/12/2018 06:36 AM, Jan Beulich wrote:
> > > > Wei Liu <wei.liu2@xxxxxxxxxx> 03/09/18 6:30 PM >>>
> > On Mon, Mar 05, 2018 at 07:38:36AM -0700, Jan Beulich wrote:
> > > > > > On 05.03.18 at 15:11, <julien.grall@xxxxxxx> wrote:
> > > > On 05/03/18 14:00, Jan Beulich wrote:
> > > > > > > > On 05.03.18 at 14:43, <julien.grall@xxxxxxx> wrote:
> > > > > > Anyway, I don't have much knowledge on the x86 to make the modification
> > > > > > that you suggested. So I am going to revert to _mfn(0) for x86.
> > > > > I'd prefer if you didn't, but well, it'll be one of us to clean it up
> > > > > then.
> > > > I can keep as INVALID_MFN. But then either you or Andrew (or anyone x86
> > > > folks) would have to provide the patch to skip incrementing invalid MFN
> > > > (if I understood correctly your request).
> > > Sigh - this should go together imo. While wrongly incrementing from
> > > zero was bad, wrongly wrapping from INVALID_MFN makes things
> > > worse.
> > Try this patch?
> Looks fine; Julien, do you want to fold this in?
Rather than folding this in,  I am planning to add this patch at the 
beginning of the series.
Cheers,

> Jan
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel