Re: [Xen-devel] [PATCH 01/12] arm:Kconfig Rename menu text

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 15/03/18 06:10, Manish Jaggi wrote:
> Hi Julien,
>
> On 03/13/2018 05:45 PM, Julien Grall wrote:
> > Hi,
> >
> > On 12/03/18 12:42, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
> > > From: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
> > >
> > > Rename the menu text to Errata Workarounds. Subsequent patches will
> > > add config options for SoC specific erratas.
> > Well, your SoC is an Arm SoC, right? So what is the benefits of this 
> > new name? M
> It was based on your last comment
>
> "I would much prefer to see the memu "ARM errata workaround via..." 
> renamed to "Errata Workarounds". So we have only one menu with all 
> workarounds."
I am fully aware that I suggested that patch. However, you still have to 
add a minimum of rationale in the commit message to understand why the 
rename. You have other people on that mailing list to look at patches...
> > ore that it still depends on HAS_ALTERNATIVE.
> check_workaroundXXX depends on it. So I kept it as is.
HAS_ALTERNATIVE is used by both arm32 and arm64.
> If you think this patch is not required, I can drop it.
The way it is does not make sense. I would prefer to drop it for now and 
just focus on the vGIC errata.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel