Re: [Xen-devel] [PATCH v9 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 3/15/18 5:23 AM, Jan Beulich wrote:
>>>> On 15.03.18 at 10:50, <roger.pau@xxxxxxxxxx> wrote:
>> On Wed, Mar 14, 2018 at 08:31:03AM -0600, Jan Beulich wrote:
>>>>>> On 14.03.18 at 15:03, <roger.pau@xxxxxxxxxx> wrote:
>>>> --- a/xen/drivers/Kconfig
>>>> +++ b/xen/drivers/Kconfig
>>>> @@ -12,4 +12,6 @@ source "drivers/pci/Kconfig"
>>>>  
>>>>  source "drivers/video/Kconfig"
>>>>  
>>>> +source "drivers/vpci/Kconfig"
>>>
>>> Are there more things to appear in that new file? If not, what the
>>> point of introducing it?
>>
>> I've assumed that was the correct hierarchy to prevent polluting
>> Kconfig files. pci/ and cpufreq/ also contain a Kconfig file with a
>> single option.
>>
>> I can move it to drivers/Kconfig if you prefer.
> 
> I would prefer that, yes (and I think it was a mistake for those
> others you mention). You may want to confirm this with others,
> in particular Doug as the kconfig maintainer, though.
> 
> Jan
> 

Well I believe they were separated out to prevent pollution at the top
level drivers/Kconfig intentionally and not by mistake. It has been some
time so I cannot recall if I made that decision unilaterally and no one
complained or if it was a review comment on the ML.

If Jan would like it in drivers/Kconfig then that works for me.

-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel