Re: [Xen-devel] [PATCH v9 11/11] vpci/msix: add MSI-X handlers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Mar 15, 2018 at 06:45:58AM -0600, Jan Beulich wrote:
> >>> On 15.03.18 at 13:01, <roger.pau@xxxxxxxxxx> wrote:
> > On Wed, Mar 14, 2018 at 11:04:00AM -0600, Jan Beulich wrote:
> >> >>> On 14.03.18 at 15:04, <roger.pau@xxxxxxxxxx> wrote:
> >> > +            process_pending_softirqs();
> >> 
> >> Careful - is this valid with a spin lock held? Note how e.g.
> >> dump_domains() holds an RCU lock only.
> > 
> > It works ATM, but I guess there could be issues if at some point the
> > softirqs need to use the vpci lock. I will add a pair of unlock/lock
> > around it.
> 
> Provided that is safe.

Hm, msix could be freed under our feet, but I don't see any other
obvious solution to this issue ATM. I think as a follow up I should
move the vpci lock outside of the vpci struct.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel