Re: [Xen-devel] [PATCH 3/7] RFC arm/domain: Reject invalid combinations of domain creation flags

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/03/18 14:42, Julien Grall wrote:
> Hi,
>
> On 12/03/18 16:32, Wei Liu wrote:
>> On Sun, Mar 11, 2018 at 07:59:16PM +0000, Julien Grall wrote:
>>> Hi Andrew,
>>>
>>> On 03/09/2018 01:18 PM, Andrew Cooper wrote:
>>>> ARM guests are HVM and have hardware assisted paging.  There are no
>>>> PV guests
>>>> or shadow paging, and all other creation flags are x86 specific.
>>>>
>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>> ---
>>>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>>> CC: Julien Grall <julien.grall@xxxxxxx>
>>>> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>>>> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
>>>>
>>>> RFC.  This is untested, but I noticed it when putting together the
>>>> preceeding
>>>> patch.  There is a moderate chance that this will cause things to
>>>> explode
>>>> because of how libxl handles ARM guest construction, but something
>>>> along these
>>>> lines is the right thing to do.
>>>
>>> Tools and hypervisor are considering ARM guests as PV. So this patch is
>>> going to break boot. There are an action (XEN-102) to move ARM
>>> guests to
>>> behave more like PVH from the tools POV. I am not sure when I will
>>> have time
>>> to look at it thought.
>>>
>>> For the time being, I am wondering if we could override the flags
>>> for Arm in
>>> the toolstack?
>>>
>>
>> Is that necessary? I don't think the rest of this series will break ARM
>> at first glance.
>
> AFAICT, the rest of the series will not break ARM. So I think it would
> be fine to just drop this patch for the time being.

I'll drop the patch for now.  This was just meant to get the problem on
peoples radar.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel