Re: [Xen-devel] [PATCH v2 45/45] ARM: VGIC: wire new VGIC(-v2) files into Xen build system

[Andre Przywara <andre.przywara@xxxxxxxxxx>]

Hi,

On 16/03/18 10:48, Jan Beulich wrote:
>>>> On 15.03.18 at 21:30, <andre.przywara@xxxxxxxxxx> wrote:
>> --- a/xen/common/Makefile
>> +++ b/xen/common/Makefile
>> @@ -19,6 +19,7 @@ obj-y += keyhandler.o
>>  obj-$(CONFIG_KEXEC) += kexec.o
>>  obj-$(CONFIG_KEXEC) += kimage.o
>>  obj-y += lib.o
>> +obj-y += list_sort.o
> 
> Why here rather than in patch 17? And why also for x86? I think you
> want a promptless Kconfig option that an arch can select if it needs
> this code, unless or until common code makes use of it.

Yeah, I had obj-$(CONFIG_NEW_VGIC) before, but Julien disliked it.
Promptless Kconfig sounds good to me.

Thanks!
Andre

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel