[Xen-devel] [PATCH 1/5] tools/firmware: Build ipxe as a standalone ROM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.18 at 18:31, <anoob.soman@xxxxxxxxxx> wrote:
> @@ -71,7 +72,7 @@ all: acpi subdirs-all
>  acpi:
>       $(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(CURDIR) 
> DSDT_FILES="$(DSDT_FILES)"
>  
> -rombios.o: roms.inc
> +rombios.o: $(ETHERBOOT_ROM) roms.inc

Please don't introduce dead dependencies: If a need for this arises
in a later patch, add the dependency there.

> @@ -113,6 +114,11 @@ endif
>  
>       mv $@.new $@
>  
> +ifneq ($(ETHERBOOT_ROMS),)
> +$(ETHERBOOT_ROM): $(ETHERBOOT_ROMS)
> +     cat $^ > $@
> +endif

I don't understand this: How can the bare concatenation of multiple
binary blobs produce anything usable? How will the consumer know
where the boundaries are, and which one is which?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel