Re: [Xen-devel] [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.18 at 18:31, <anoob.soman@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/config.h
> +++ b/tools/firmware/hvmloader/config.h
> @@ -33,6 +33,11 @@ struct bios_config {
>      void (*create_mp_tables)(void);
>      void (*create_smbios_tables)(void);
>      void (*create_pir_tables)(void);
> +
> +    /* Physical address of iPXE ROM, loaded by domain builder
> +     * when using ROMBIOS
> +     */
> +    unsigned int *ipxe_rom_addresss;

Comment style. And can the pointer be to const?

> @@ -368,7 +370,12 @@ int main(void)
>  #ifdef ENABLE_ROMBIOS
>      else if ( bios == &rombios_config )
>      {
> -        bios->bios_load(bios, NULL, 0);
> +        ipxe_module = get_module_entry(hvm_start_info, "ipxe");
> +
> +        if ( ipxe_module )
> +            ipxe_rom_addresss = ipxe_module->paddr;
> +
> +        bios->bios_load(bios, (void *)ipxe_rom_addresss, 0);
>      }
>  #endif

Considering the #ifdef around here - is this whole series an
enhancement for qemu-trad only? I don't think we mean to make
any such enhancements anymore.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel