Re: [Xen-devel] [PATCH v10 09/11] vpci/msi: add MSI handlers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Mar 16, 2018 at 10:24:04AM -0600, Jan Beulich wrote:
> >>> On 16.03.18 at 16:38, <roger.pau@xxxxxxxxxx> wrote:
> > On Fri, Mar 16, 2018 at 09:05:44AM -0600, Jan Beulich wrote:
> >> >>> On 16.03.18 at 15:34, <roger.pau@xxxxxxxxxx> wrote:
> >> > vpci_remove_device is never called from the user-space test harness,
> >> > so it just needs to build, but not necessarily be correct in that
> >> > context.
> >> > 
> >> > The test harness doesn't use vpci_add_handlers or vpci_remove_device,
> >> > it just adds and removes handlers using vpci_add_register and
> >> > vpci_remove_register.
> >> 
> >> I dislike such a setup - then you'd better #ifdef out the entire
> >> function, and undo some of the other recently added #ifdef-ary.
> > 
> > OK, I've done it that way initially to prevent polluting vpci.c with
> > __XEN__ ifdefs. The patch below ifdefs those unused functions.
> 
> Looks like an overall improvement to me.

Would you be fine with this being a separate patch, or would you like
me to squash it into the series?

I think if you don't have other comments that require a new version of
the series a separate patch should be OK.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel