[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 24/45] ARM: new VGIC: Add CTLR, TYPER and IIDR handlers



Hi Andre,

On 03/15/2018 08:30 PM, Andre Przywara wrote:
diff --git a/xen/arch/arm/vgic/vgic.h b/xen/arch/arm/vgic/vgic.h
index 7f221fd195..e2d0f04440 100644
--- a/xen/arch/arm/vgic/vgic.h
+++ b/xen/arch/arm/vgic/vgic.h
@@ -17,6 +17,10 @@
  #ifndef __XEN_ARM_VGIC_VGIC_H__
  #define __XEN_ARM_VGIC_VGIC_H__
+#define PRODUCT_ID_KVM 0x4b /* ASCII code X */

I think you mean 'ASCII code K'.

Also, do you want to copy the commit message about the identifier in the code?

+#define VARIANT_ID_XEN          0x01
+#define IMPLEMENTER_ARM         0x43b
+
  #define vgic_irq_is_sgi(intid) ((intid) < VGIC_NR_SGIS)
static inline bool irq_is_pending(struct vgic_irq *irq)
@@ -37,6 +41,7 @@ struct vgic_irq *vgic_get_irq(struct domain *d, struct vcpu 
*vcpu,
  void vgic_put_irq(struct domain *d, struct vgic_irq *irq);
  void vgic_queue_irq_unlock(struct domain *d, struct vgic_irq *irq,
                             unsigned long flags);
+void vgic_kick_vcpus(struct domain *d);
static inline void vgic_get_irq_kref(struct vgic_irq *irq)
  {


Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.