Re: [Xen-devel] [PATCH 05/20] arm/boot: Mark construct_dom0() as __init

[Julien Grall <julien.grall@xxxxxxx>]

On 03/20/2018 03:40 AM, Julien Grall wrote:
> Hi Andrew,
>
> On 03/19/2018 07:13 PM, Andrew Cooper wrote:
> > Its sole caller, start_xen(), is __init.
> Actually, most of that files could benefits of __init as this is domain 
> only build.
> In any case, this patch is already a good start. So:
>
> Acked-by: Julien Grall <julien.grall@xxxxxxx>
Committed.

Cheers,

> Cheers,
>
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> > CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > CC: Julien Grall <julien.grall@xxxxxxx>
> > ---
> >   xen/arch/arm/domain_build.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 28ee876..9ef9030 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -2094,7 +2094,7 @@ static void __init find_gnttab_region(struct 
> > domain *d,
> >              kinfo->gnttab_start, kinfo->gnttab_start + 
> > kinfo->gnttab_size);
> >   }
> > -int construct_dom0(struct domain *d)
> > +int __init construct_dom0(struct domain *d)
> >   {
> >       struct kernel_info kinfo = {};
> >       struct vcpu *saved_current;
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel