Re: [Xen-devel] [PATCH v5 14/16] xen/grant: Switch common/grant_table.c to use typesafe MFN

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

On 03/15/2018 08:14 AM, Jan Beulich wrote:
> > > > On 14.03.18 at 19:20, <julien.grall@xxxxxxx> wrote:
> > From: Julien Grall <julien.grall@xxxxxxx>
> >
> > At the same time replace _mfn(0) by INVALID_MFN or drop the initializer
> > when it is not necessary. This will make clearer that the MFN
> > initialized is not valid.
> >
> > Other than _mfn(0) -> INVALID_MFN, no functional change intended.
> There's no such transformation in the patch, so I think it would
> be better if you said "0" or "MFN 0" instead of "_mfn(0)" in both
> instances above.
Good point. I will update the commit message.


> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel