Re: [Xen-devel] [PATCH 3/3] x86/pv: Minor tweaks to {, compat_}register_guest_callback()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.18 at 12:58, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/pv/callback.c
> +++ b/xen/arch/x86/pv/callback.c
> @@ -71,10 +71,11 @@ static void unregister_guest_nmi_callback(void)
>      memset(t, 0, sizeof(*t));
>  }
>  
> -static long register_guest_callback(struct callback_register *reg)
> +static int register_guest_callback(struct callback_register *reg)
>  {
> -    long ret = 0;
>      struct vcpu *curr = current;
> +    struct pv_vcpu *pv = &curr->arch.pv_vcpu;
> +    int ret = 0;

Instead of altering ret's type, why don't you drop it altogether?
Same actually for the unregister function in patch 2. Preferably
with that done
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel