Re: [Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Mar 20, 2018 at 11:43:00AM +0000, Roger Pau Monné wrote:
> On Tue, Mar 20, 2018 at 05:03:09AM -0600, Jan Beulich wrote:
> > >>> On 16.03.18 at 14:30, <roger.pau@xxxxxxxxxx> wrote:
> > > +            printk(XENLOG_G_WARNING
> > > +                   "Failed to remove MSIX table [%" PRI_gfn ", %" 
> > > PRI_gfn "]: %d\n",
> > > +                   PFN_DOWN(start), PFN_DOWN(end), rc);
> > 
> > In cases like this (where you don't use plain start/end anywhere,
> > but you do use the same calculation on them twice each), it's
> > certainly more efficient for the local variables to be frame numbers
> > right away.
> 
> Right, I've fixed it and also changed the printf formatters to lu, I
> guess at some point in the series I used to print gfn values.

Meant lx not lu...

Sorry.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel