[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] qemu: include generated files with <> and not ""
- To: Daniel P. Berrangé <berrange@xxxxxxxxxx>
- From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
- Date: Tue, 20 Mar 2018 14:32:16 +0100
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, Dmitry Fleytman <dmitry.fleytman@xxxxxxxxx>, sheepdog@xxxxxxxxxxxxxx, Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jeff Cody <jcody@xxxxxxxxxx>, Zhang Chen <zhangckid@xxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, "Richard W.M. Jones" <rjones@xxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Subbaraya Sundeep <sundeep.lkml@xxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Josh Durgin <jdurgin@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, zhanghailiang <zhang.zhanghailiang@xxxxxxxxxx>, Ben Warren <ben@xxxxxxxxxxxxxxxxxx>, Marcel Apfelbaum <marcel@xxxxxxxxxx>, Yongbok Kim <yongbok.kim@xxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Hervé Poussineau <hpoussin@xxxxxxxxxxx>, Shannon Zhao <zhaoshenglong@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Liu Yuan <namei.unix@xxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Andrzej Zaborowski <balrogg@xxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Riku Voipio <riku.voipio@xxxxxx>, Fam Zheng <famz@xxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Corey Minyard <minyard@xxxxxxx>, Amit Shah <amit@xxxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Alistair Francis <alistair@xxxxxxxxxxxxx>, Peter Lieven <pl@xxxxxxx>, "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Fabien Chouteau <chouteau@xxxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Peter Chubb <peter.chubb@xxxxxxxxxxxx>, Yuval Shaia <yuval.shaia@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, BALATON Zoltan <balaton@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, qemu-block@xxxxxxxxxx, Peter Crosthwaite <crosthwaite.peter@xxxxxxxxx>, Hitoshi Mitake <mitake.hitoshi@xxxxxxxxxxxxx>, Wen Congyang <wencongyang2@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, Cornelia Huck <cohuck@xxxxxxxxxx>, Laurent Vivier <laurent@xxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, qemu-ppc@xxxxxxxxxx, Andreas Färber <afaerber@xxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
- Delivery-date: Tue, 20 Mar 2018 13:32:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
> > So for these, we should use "". None of these are generated files though.
>
> That leads to crazy inconsistent message for developers where 50% of QEMU
> header files must use <> and the other 50% of header files must use "".
The rules are pretty simple though:
(1) Headers which are generated use <>.
(2) Headers which are in include/ use <>.
(3) Headers sitting in the same directory as the source files use "".
Other cases should not exist (when headers from another source directory
are included they should most likely be moved to include/).
cheers,
Gerd
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
