Re: [Xen-devel] [PATCH v2 3/4] x86/hvm: re-structure some of the ioreq server look-up loops

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.03.18 at 17:58, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/ioreq.c
> +++ b/xen/arch/x86/hvm/ioreq.c
> @@ -839,37 +839,37 @@ int hvm_map_io_range_to_ioreq_server(struct domain *d, 
> ioservid_t id,
>                            &d->arch.hvm_domain.ioreq_server.list,
>                            list_entry )
>      {
> +        struct rangeset *r;
> +
>          if ( s == d->arch.hvm_domain.default_ioreq_server )
>              continue;
>  
> -        if ( s->id == id )
> -        {
> -            struct rangeset *r;
> -
> -            switch ( type )
> -            {
> -            case XEN_DMOP_IO_RANGE_PORT:
> -            case XEN_DMOP_IO_RANGE_MEMORY:
> -            case XEN_DMOP_IO_RANGE_PCI:
> -                r = s->range[type];
> -                break;
> +        if ( s->id != id )
> +            continue;
>  
> -            default:
> -                r = NULL;
> -                break;
> -            }
> +        switch ( type )
> +        {
> +        case XEN_DMOP_IO_RANGE_PORT:
> +        case XEN_DMOP_IO_RANGE_MEMORY:
> +        case XEN_DMOP_IO_RANGE_PCI:
> +            r = s->range[type];
> +            break;
>  
> -            rc = -EINVAL;
> -            if ( !r )
> -                break;
> +        default:
> +            r = NULL;
> +            break;
> +        }
>  
> -            rc = -EEXIST;
> -            if ( rangeset_overlaps_range(r, start, end) )
> +        rc = -EINVAL;
> +        if ( !r )
>                  break;

The break now looks to be mis-indented. With that cleaned up
(which probably could also be done while committing)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel