[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 11/20] xen/domctl: Merge set_gnttab_limits into createdomain
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>
- From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Date: Tue, 20 Mar 2018 15:27:24 -0400
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Jon Ludlam <jonathan.ludlam@xxxxxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>
- Delivery-date: Tue, 20 Mar 2018 19:27:33 +0000
- Ironport-phdr: 9a23:xp5ZrRy8NlVXuQvXCy+O+j09IxM/srCxBDY+r6Qd0u4XLfad9pjvdHbS+e9qxAeQG9mDsLQc06L/iOPJYSQ4+5GPsXQPItRndiQuroEopTEmG9OPEkbhLfTnPGQQFcVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZvJuTyB4Xek9m72/q99pHPbQhEniaxba9vJxiqsAvdsdUbj5F/Iagr0BvJpXVIe+VSxWx2IF+Yggjx6MSt8pN96ipco/0u+dJOXqX8ZKQ4UKdXDC86PGAv5c3krgfMQA2S7XYBSGoWkx5IAw/Y7BHmW5r6ryX3uvZh1CScIMb7Vq4/Vyi84Kh3SR/okCYHOCA/8GHLkcx7kaZXrAu8qxBj34LYZYeYO/RkfqPZYNgUW2xPUMhMXCBFG4+wcZcDA+8HMO1FrYfyukEOoAOjCweyCuPhyjxGiHH40qI10esuDQ7I0Rc8H98MqnnYsMn5OakQXO2z0aLGzS/Db/RT2Trl5obHaBYhofCSUrJ0bMHfx1cgHB7EgFWKs4PqJT2V3fkKvmeG4OpvSPygi2E9qw5ruTWv2scthZXJhoIS0FzE8z55z5wvKd23T057f8epHZ1NvC+ZL4t7Wt4uTm5ntSogyrAKpIS3cDYFxZg53RLTdvqKeJWS7B35TuaeOzJ4iWpgeLK4mhm971Ctyvb5VsmoyFZKqTdFksXUunANyRPT7s+HR+Nh/ki7wzaP1h3T6vpeLUAolavUN54hwrkqmpoVrUvDBTP5lF/zjK+XckUo4umo6+L5bbX6vpKQKoB5hw7kPqkuh8CzG/o0PwcQU2SB5OiwzLjj8lf4QLVOgP02iK7ZsJXCKMsGqa62HhFa0ok56xmlFDqmzNQZkmUHLFJCYh6HiZPpNEvULPD3Cve/nUygkC13yPDeIr3hHpLNI2DZn7fnYLl98VBTyQQpwd9D4JJUDakBL+zpWkL/r9HXEh45MxCuw+bmB9RxzJ8RWWWKAqWBKqPdrUeI5v4zI+mLfIIUtyjyK/486/Hzk3A5h0ESfa2y0JsTaXC4BehmI16DbXvjnNgBF30Gvg0kTOzlkFeCSyJcZ26uX6Ig4TE2EIaoAJrdSYCwhLyB3Tu0Hp1Na2BdF1CMCmnne5+YVPcLbSKYOtVhnSAcVbi9V48h0gmjugzgxLphNOba/jcXuo7g1Nhu4O3Tkwo/+iJpD8iHz26NTn10nnkJRz45xqxwvUt9ylKb26hin/NYDcBT5+9OUgoiO5/T0e16B8r2WgLAY9eFVk2rTcmnATEtVNIxwtAPb1xhFNWlixDJxzCqDKMNl7yXGJw09brR0GTxJ8ZnynbGz7Uhj1g8TctJL2Gmgq9/9w7OCI7InEWUjLqldaUA3C7X9WeCwnCCs11fUA51Sa/FR2wQZlPKrdTl4UPPV6KhBq45MgRf0sOCMLVFZcHujVVHQPfvItPeY3i+m22oHxaH2quMbJb2e2UaxCjdCk8EkwYJ8naaNQgxHCGhr3jaDDxzCF3vZ1nj8exlpXylU0841R2Fb0x917qv+x4UiuaQRO8U3rIBoC0hsSl7HE6h39LKDNqNvxZvfKJHbt8n4llH0nzWtxdmM5O8LqBimkQecwV4vk/0yxp3DYBAm9AwrHw21ApyNb6Y0FRZejOdx5/wILjXJXPo/B+xaK7bwVDe0NCI+qcO8/Q4qk7svAW3GUo+83Vn0t9V03SH5pXOFgUdSoj9XVow9xh/9PnmZXwU4Y/O2GIkGq6zqjLYk4YgAuc/xwnmdNBYKK6eTyf5EtEABtjoI+svzRzhXh8Ceexf6qMwd5e2ev3D1KO1MeJImDO9kX8B8I17lEWW+HwvZPTP2sMpyveZ0w/Pezq0o02ou86/zYxLaTwdBGOX1TnvBIkXYLZ7O4kMFzH9cIWM2txiisu1CDZj/1m5CgZDgZXxdA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/19/2018 03:13 PM, Andrew Cooper wrote:
XEN_DOMCTL_set_gnttab_limits is a fairly new hypercall, and is strictly
mandatory. Adding support for it introduced a state where a domain has a
mostly un-constructed grant table, and there were cases where mis-ordering of
toolstack hypercalls could cause a NULL pointer deference in the hypervisor.
In fixing this, the grant table initialisation code became very tangled.
As the settings are mandatory, delete XEN_DOMCTL_set_gnttab_limits (including
XSM hooks and libxc wrappers) and retain the functionality in
XEN_DOMCTL_createdomain.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
