Re: [Xen-devel] [PATCH v10 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 20, 2018 at 05:10:09AM -0600, Jan Beulich wrote:
> >>> On 16.03.18 at 14:29, <roger.pau@xxxxxxxxxx> wrote:
> > This functionality is going to reside in vpci.c (and the corresponding
> > vpci.h header), and should be arch-agnostic. The handlers introduced
> > in this patch setup the basic functionality required in order to trap
> > accesses to the PCI config space, and allow decoding the address and
> > finding the corresponding handler that should handle the access
> > (although no handlers are implemented).
> > 
> > Note that the traps to the PCI IO ports registers (0xcf8/0xcfc) are
> > setup inside of a x86 HVM file, since that's not shared with other
> > arches.
> > 
> > A new XEN_X86_EMU_VPCI x86 domain flag is added in order to signal Xen
> > whether a domain should use the newly introduced vPCI handlers, this
> > is only enabled for PVH Dom0 at the moment.
> > 
> > A very simple user-space test is also provided, so that the basic
> > functionality of the vPCI traps can be asserted. This has been proven
> > quite helpful during development, since the logic to handle partial
> > accesses or accesses that expand across multiple registers is not
> > trivial.
> > 
> > The handlers for the registers are added to a linked list that's keep
> > sorted at all times. Both the read and write handlers support accesses
> > that expand across multiple emulated registers and contain gaps not
> > emulated.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> > [IO parts]
> > Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Stefano, Julien,
> 
> any chance of getting an ack for the smallish ARM side change
> here (assuming your earlier concerns have been addressed)?
> 
> Ian, Wei,
> 
> along those lines (iirc there were no prior concerns) for the tiny
> libxl part? (I think the new test code doesn't strictly belong under
> tools/ maintainership, just like the x86_emulator one doesn't.)

Here you go:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel