Re: [Xen-devel] [for-4.11][PATCH v6 03/16] xen/arm: mm: Use gaddr_to_gfn rather than _gfn(paddr_to_pfn(...))

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 03/21/2018 04:47 AM, Julien Grall wrote:
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
>
> ---
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Sorry I added in the changelog but forgot to add George's reviewed-by

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Cheers,

>      Changes in v6:
>          - Remove the justification from the commit message
>          - Add George's reviewed-by
>
>      Changes in v4:
>          - Patch added
> ---
>   xen/arch/arm/mm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index baa3b0de1d..1126e246c0 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1431,7 +1431,7 @@ int create_grant_host_mapping(unsigned long addr, 
> unsigned long frame,
>       if ( flags & GNTMAP_readonly )
>           t = p2m_grant_map_ro;
>   
> -    rc = guest_physmap_add_entry(current->domain, _gfn(addr >> PAGE_SHIFT),
> +    rc = guest_physmap_add_entry(current->domain, gaddr_to_gfn(addr),
>                                    _mfn(frame), 0, t);
>   
>       if ( rc )
> @@ -1443,7 +1443,7 @@ int create_grant_host_mapping(unsigned long addr, 
> unsigned long frame,
>   int replace_grant_host_mapping(unsigned long addr, unsigned long mfn,
>           unsigned long new_addr, unsigned int flags)
>   {
> -    gfn_t gfn = _gfn(addr >> PAGE_SHIFT);
> +    gfn_t gfn = gaddr_to_gfn(addr);
>       struct domain *d = current->domain;
>       int rc;
>   
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel