[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxc/arm: initialise p2m_size to make gcc happy



Hi,

On 03/21/2018 04:43 PM, Wei Liu wrote:
On Wed, Mar 14, 2018 at 01:27:37PM +0000, Julien Grall wrote:
Hi,

On 03/14/2018 12:32 PM, Wei Liu wrote:
Gcc with -O3 failed to spot the loop to initialise p2m_size runs at
least once.

Aside, Andrew's comment the patch looks okay. But I am wondering why we need
to allocate p2m_host for Arm?


Not sure, really. :-)

 From a quick look I have seen no real user except xc_dom_update_guest_p2m
that can cope with p2m_host = NULL.


Maybe it is to work around this limitation in code.

I will have a look at it. Meanwhile, I guess it is better to make GCC happy with that patch.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.