Re: [Xen-devel] [PATCH v3 3/7] xen/x86: support per-domain flag for xpti

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.03.18 at 16:29, <jgross@xxxxxxxx> wrote:
> On 22/03/18 16:26, Jan Beulich wrote:
>>>>> On 21.03.18 at 13:51, <jgross@xxxxxxxx> wrote:
>>> +void xpti_domain_init(struct domain *d)
>>> +{
>>> +    if ( !is_pv_domain(d) || is_pv_32bit_domain(d) )
>>> +        return;
>> 
>> As you rely on the zero-initialization of the field here, ...
>> 
>>> +    switch ( opt_xpti )
>>> +    {
>>> +    case XPTI_OFF:
>>> +        d->arch.pv_domain.xpti = false;
>> 
>> ... this could go away as well.
> 
> I wanted to make the switch statement complete. No problem to drop
> setting of xpti here of you like that better.

FAOD I didn't mean dropping the entire case block.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel