[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 1/2] make: move generated headers to qemu-build/
- To: Eric Blake <eblake@xxxxxxxxxx>
- From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
- Date: Thu, 22 Mar 2018 22:04:26 +0200
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, Dmitry Fleytman <dmitry.fleytman@xxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jeff Cody <jcody@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, BALATON Zoltan <balaton@xxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Fam Zheng <famz@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Yongbok Kim <yongbok.kim@xxxxxxxx>, Josh Durgin <jdurgin@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, zhanghailiang <zhang.zhanghailiang@xxxxxxxxxx>, Ben Warren <ben@xxxxxxxxxxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>, "Richard W.M. Jones" <rjones@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Hervé Poussineau <hpoussin@xxxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, Shannon Zhao <zhaoshenglong@xxxxxxxxxx>, Marcel Apfelbaum <marcel@xxxxxxxxxx>, Liu Yuan <namei.unix@xxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Andrzej Zaborowski <balrogg@xxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Alistair Francis <alistair@xxxxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Corey Minyard <minyard@xxxxxxx>, Amit Shah <amit@xxxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Riku Voipio <riku.voipio@xxxxxx>, Peter Lieven <pl@xxxxxxx>, "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Yuval Shaia <yuval.shaia@xxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Peter Chubb <peter.chubb@xxxxxxxxxxxx>, Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>, Zhang Chen <zhangckid@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, John Snow <jsnow@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Daniel P. Berrangé <berrange@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Peter Crosthwaite <crosthwaite.peter@xxxxxxxxx>, Hitoshi Mitake <mitake.hitoshi@xxxxxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Laurent Vivier <laurent@xxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, Subbaraya Sundeep <sundeep.lkml@xxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Wen Congyang <wencongyang2@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Andreas Färber <afaerber@xxxxxxx>, Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
- Delivery-date: Thu, 22 Mar 2018 20:04:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 22, 2018 at 02:42:55PM -0500, Eric Blake wrote:
> On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote:
> > Make sure all generated files go into qemu-build subdirectory.
> > We can then include them like this:
> > #include "qemu-build/trace.h"
> >
> > This serves two purposes:
> > - make it easy to detect which files are in the source
> > directory (a bit more work for writers, easier for readers)
> > - reduce chances of conflicts with possible stale files in source
> > directory (which could be left over from e.g. old patches, etc)
> >
> > This patch needs to be merged with patch 2 of series updating all
> > files: sending it separately to avoid spamming the list.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > ---
>
> > +++ b/Makefile
> > @@ -89,102 +89,102 @@ endif
> > include $(SRC_PATH)/rules.mak
> > -GENERATED_FILES = qemu-version.h config-host.h qemu-options.def
> > -GENERATED_FILES += qapi/qapi-builtin-types.h qapi/qapi-builtin-types.c
>
> Uggh - I really need to follow up on my threat to make smarter use of make
> variables and string manipulation to cut down on the boilerplate involved
> here. Sadly, I'm not convinced that doing so is a 2.12 bugfix priority, so
> it isn't at the top of my work queue.
>
> Overall, the patch is an interesting idea. I'm still not 100% sold on it
> (as you say, it's now slightly more work for writers), but I'm not coming up
> with any solid reasons why it should not be applied (at least, for 2.13 -
> doing it during freeze for 2.12 is a bit harder to justify).
It's up to Peter really: it helps reduce conflicts if we apply patches
like this during freeze. But with enough effort on Pater's part it's
not a huge deal.
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
