Re: [Xen-devel] [PATCH 13/20] xen/evtchn: Pass max_evtchn_port into evtchn_init()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.03.18 at 20:13, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -693,7 +693,9 @@ void __init start_xen(unsigned long boot_phys_offset,
>      const char *cmdline;
>      struct bootmodule *xen_bootmodule;
>      struct domain *dom0;
> -    struct xen_domctl_createdomain dom0_cfg = {};
> +    struct xen_domctl_createdomain dom0_cfg = {
> +        .max_evtchn_port = -1,
> +    };
>  
>      dcache_line_bytes = read_dcache_line_bytes();
>  
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -673,6 +673,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>      };
>      struct xen_domctl_createdomain dom0_cfg = {
>          .flags = XEN_DOMCTL_CDF_s3_integrity,
> +        .max_evtchn_port = -1,
>      };

Any chance I can talk you into using INT_MAX, UINT_MAX, or ~0u
in both cases above, seeing that max_evtchn_port's type is
unsigned int? Other than this
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel