Re: [Xen-devel] [PATCH] x86/vpci: validate data first in register_vpci_mmcfg_handler

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Mar 27, 2018 at 12:04:20PM +0100, Wei Liu wrote:
> Avoid the need to deallocate memory when the data is invalid. It has
> the benefit to not fragment memory in Xen.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> Found by code inspection. There shouldn't be any practical difference
> in our current setup because the function is hardware domain only.
> But ISTM the plan is to make this available to DomU in the future so
> we'd better be careful about buggy / malicious guests.

This function must be called by the toolstack, guests won't be allowed
to register MCFG regions themselves anyway, so there should be no
guest path that leads here.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel