Re: [Xen-devel] [PATCH] shim: update config after vpci patches

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 27, 2018 at 03:41:57PM +0100, Roger Pau Monné wrote:
> On Tue, Mar 27, 2018 at 03:12:35PM +0100, Wei Liu wrote:
> > On Tue, Mar 27, 2018 at 03:09:42PM +0100, Roger Pau Monné wrote:
> > > On Tue, Mar 27, 2018 at 02:58:13PM +0100, Wei Liu wrote:
> > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > > ---
> > > >  tools/firmware/xen-dir/shim.config | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/tools/firmware/xen-dir/shim.config 
> > > > b/tools/firmware/xen-dir/shim.config
> > > > index 4d5630f87a..05071bf436 100644
> > > > --- a/tools/firmware/xen-dir/shim.config
> > > > +++ b/tools/firmware/xen-dir/shim.config
> > > > @@ -67,6 +67,7 @@ CONFIG_HAS_EHCI=y
> > > >  CONFIG_HAS_CPUFREQ=y
> > > >  CONFIG_HAS_PASSTHROUGH=y
> > > >  CONFIG_HAS_PCI=y
> > > > +CONFIG_HAS_VPCI=y
> > > 
> > > If the PV_SHIM_EXCLUSIVE option is selected HAS_VPCI should be forced
> > > to n, but this requires further changes to Kconfig.
> > 
> > I agree. PCI, PASSTHROUGH and bunch of others should also be n.  But I
> > don't think we can get there any time soon.
> 
> What about using something like the following:
> 
> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> index c405c4bf4f..f64fc56739 100644
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -23,7 +23,7 @@ config X86
>       select HAS_PCI
>       select HAS_PDX
>       select HAS_UBSAN
> -     select HAS_VPCI
> +     select HAS_VPCI if !PV_SHIM_EXCLUSIVE

Looks OK to me.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel