Re: [Xen-devel] [PATCH resend 02/13] acpi: arm: query estimated size of hardware domain's IORT.

[Manish Jaggi <mjaggi@xxxxxxxxxxxxxxxxxx>]

Hi Julien,

On 03/21/2018 03:42 PM, Julien Grall wrote:
> Title: Please drop the full stop.
>
> On 03/13/2018 03:20 PM, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
> ...
>
> > +    struct rid_devid_map *rmap;
> I am sorry but I still don't see any comment about my comment on the 
> previous version. For reminder:
> "A bit more documention of this function would be appreciated. For 
> instance, the rationale between browsing the list twice for allocation.
> I actually do think this might be avoidable by storing a bit more 
> information from the IORT. From the table you can easily deduced the 
> number of root complex and ITS group. 
That will still require parsing of all IORT nodes.
I am add one more api to return total mappings, which would basically 
return a counter which is updated when add_rid_deviceid_map is called.
This would replace

+    list_for_each_entry(rmap, &rid_devid_list, entry)
+        count++;
+

Sounds good?
> They could be store with the rest of information."

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel