[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 4/7] xen/x86: use invpcid for flushing the TLB
>>> On 27.03.18 at 11:07, <jgross@xxxxxxxx> wrote: > If possible use the INVPCID instruction for flushing the TLB instead of > toggling cr4.pge for that purpose. > > While at it remove the dependency on cr4.pge being required for mtrr > loading, as this will be required later anyway. > > Add a command line option "invpcid" for controlling the use of > INVPCID (default to true). > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> with one remarks (which could be addressed while committing): > @@ -71,6 +72,25 @@ static void post_flush(u32 t) > this_cpu(tlbflush_time) = t; > } > > +static void do_tlb_flush(void) > +{ > + u32 t; > + > + t = pre_flush(); In the original code this was the initializer of the variable, and I'd prefer if that stayed that way (unless later changes require the split). Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |