[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1] fuzz: wrappers.c depends on x86_emulate.h
>>> On 29.03.18 at 14:01, <olaf@xxxxxxxxx> wrote: > --- a/tools/fuzz/x86_instruction_emulator/Makefile > +++ b/tools/fuzz/x86_instruction_emulator/Makefile > @@ -18,6 +18,8 @@ asm: > > asm/%: asm ; > > +wrappers.o: $(x86_emulate.h) > + > x86-emulate.c x86-emulate.h wrappers.c: %: > [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$* It certainly feels odd to request a v2 on this simple a change, but the addition shouldn't be put in a random place. Instead we already have # x86-emulate.c will be implicit for both x86-emulate.o x86-emulate-cov.o: x86_emulate/x86_emulate.c $(x86_emulate.h) fuzz-emul.o fuzz-emulate-cov.o: $(x86_emulate.h) which the new one should be grouped with. Otoh maybe I should just move the line while committing. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |