Re: [Xen-devel] [PATCH v18 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.03.18 at 11:53, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 26 March 2018 12:41
>> 
>> >>> On 22.03.18 at 12:55, <paul.durrant@xxxxxxxxxx> wrote:
>> > --- a/xen/include/xlat.lst
>> > +++ b/xen/include/xlat.lst
>> > @@ -86,6 +86,7 @@
>> >  ! memory_map                      memory.h
>> >  ! memory_reservation              memory.h
>> >  ! mem_access_op                   memory.h
>> > +! mem_acquire_resource            memory.h
>> 
>> Why ! ? The layout doesn't appear to differ between native and
>> compat. Or wait, the handle does, but why is that not
>> XEN_GUEST_HANDLE_64()? (I've skipped the compat layer code
>> in this round of review for that reason.)
> 
> It's been XEN_GUEST_HANDLE throughout all but the earliest revisions of the 
> patch and I have not modified the compat code massively since you gave your 
> R-b anyway... the only thing that changed was copying back the new flags 
> value.

Granted I could/should have noticed this earlier, but being able to
get away without compat translation would certainly be a win, and
we have that option since this is a tools-only interface.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel