Re: [Xen-devel] [PATCH v7] new config option vtsc_tolerance_khz to avoid TSC emulation

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/04/18 19:25, Olaf Hering wrote:
> On Sun, Apr 01, Andrew Cooper wrote:
>
>> On 01/04/18 18:03, Olaf Hering wrote:
>>> diff --git a/tools/libxc/xc_sr_stream_format.h 
>>> b/tools/libxc/xc_sr_stream_format.h
>>> index 15ff1c7efb..9b52f6ace6 100644
>>> --- a/tools/libxc/xc_sr_stream_format.h
>>> +++ b/tools/libxc/xc_sr_stream_format.h
>>> @@ -121,7 +121,8 @@ struct xc_sr_rec_tsc_info
>>> -    uint32_t _res1;
>>> +    uint16_t vtsc_tolerance;
>>> +    uint16_t _res1;
>> You need to similarly tweak verify_record_tsc_info() in
>> tools/python/xen/migration/libxc.py
> Thanks. I think this simple change is enough?

Yeah - That looks ok, although I'd add a kHz unit to the printed tolerance.

~Andrew

>
> --- a/tools/python/xen/migration/libxc.py
> +++ b/tools/python/xen/migration/libxc.py
> @@ -114,7 +114,7 @@ X86_PV_P2M_FRAMES_FORMAT  = "II"
>  X86_PV_VCPU_HDR_FORMAT    = "II"
>  
>  # tsc_info
> -TSC_INFO_FORMAT           = "IIQII"
> +TSC_INFO_FORMAT           = "IIQIHH"
>  
>  # hvm_params
>  HVM_PARAMS_ENTRY_FORMAT   = "QQ"
> @@ -363,14 +363,14 @@ class VerifyLibxc(VerifyBase):
>          if len(content) != sz:
>              raise RecordError("Length should be %u bytes" % (sz, ))
>  
> -        mode, khz, nsec, incarn, res1 = unpack(TSC_INFO_FORMAT, content)
> +        mode, khz, nsec, incarn, tolerance, res1 = unpack(TSC_INFO_FORMAT, 
> content)
>  
>          if res1 != 0:
>              raise StreamError("Reserved bits set in TSC_INFO: 0x%08x"
>                                % (res1, ))
>  
> -        self.info("  Mode %u, %u kHz, %u ns, incarnation %d"
> -                  % (mode, khz, nsec, incarn))
> +        self.info("  Mode %u, %u kHz, %u ns, incarnation %d tolerance %u"
> +                  % (mode, khz, nsec, incarn, tolerance))
>  
>  
>      def verify_record_hvm_context(self, content):
>
> Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel