Re: [Xen-devel] [PATCH] Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Mar 30, 2018 at 10:31:53AM -0700, Stefano Stabellini wrote:
> Add a short entry to the xl.cfg man page about pvcalls.
> Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in
> libxl.
> 
> Signed-off-by: Stefano Stabellini <stefano@xxxxxxxxxxx>
> ---
>  docs/man/xl.cfg.pod.5.in | 7 +++++++
>  tools/libxl/libxl.h      | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> index 2c1a6e1..47d8824 100644
> --- a/docs/man/xl.cfg.pod.5.in
> +++ b/docs/man/xl.cfg.pod.5.in
> @@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
>  
>  =back
>  
> +=item B<pvcalls=[ "backend=domain-id", ... ]>

The 'backend' parameter in the disk config [0] contains the domain name,
not the domain id. I think it would be good to keep the same
semantics for both.

Thanks, Roger.

[0] https://xenbits.xen.org/docs/unstable/man/xl-disk-configuration.5.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel