Re: [Xen-devel] [PATCH v19 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

[Julien Grall <julien.grall@xxxxxxx>]

Hi Paul,

On 29/03/18 16:36, Paul Durrant wrote:
> Certain memory resources associated with a guest are not necessarily
> present in the guest P2M.
>
> This patch adds the boilerplate for new memory op to allow such a resource
> to be priv-mapped directly, by either a PV or HVM tools domain.
>
> NOTE: Whilst the new op is not intrinsicly specific to the x86 architecture,
s/intrinsicly/intrinsically/ I think.

[..]

> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
> index 45ef2cd58b..4d036b6112 100644
> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -344,6 +344,16 @@ static inline gfn_t gfn_next_boundary(gfn_t gfn, unsigned 
> int order)
>       return gfn_add(gfn, 1UL << order);
>   }
>   
> +static inline int set_foreign_p2m_entry(struct domain *d, unsigned long gfn,
> +                                        mfn_t mfn)
> +{
> +    /*
> +     * NOTE: If this is implemented then proper reference counting of
> +     *       foreign entries will need to be impmemented.
s/impmenmented/implemented/

For ARM-bits:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> +     */
> +    return -EOPNOTSUPP;
> +}
> +
>   #endif /* _XEN_P2M_H */
>   
>   /*
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel