Re: [Xen-devel] [PATCH v3 1/2] libxl: Implement the handler to handle unrecoverable AER errors [and 1 more messages]

[Venu Busireddy <venu.busireddy@xxxxxxxxxx>]

On 2018-04-03 16:06:17 +0100, Ian Jackson wrote:
> Venu Busireddy writes ("[RESEND PATCH v5 0/2] Containing AER unrecoverable 
> errors"):
> > This patch set is part of a set of patches that together allow containment
> > of unrecoverable AER errors from PCIe devices assigned to guests in
> > passthrough mode. The containment is achieved by forcibly removing the
> > erring PCIe device from the guest.
> 
> But, in September, I wrote:
> 
> Ian Jackson writes ("Re: [PATCH v3 1/2] libxl: Implement the handler to 
> handle unrecoverable AER errors"):
> > I'm afraid that I still have reservations about the design questions.
> > Evidently I didn't make my questions clear enough.
> > 
> > [ 64 lines of detailed discussion elided ]
> 
> I haven't seen a reply to that.

Reply to that is the v5 patch. Your concern in v4 was, "why is this
error handling done only in some cases?" Meaning, the error handling
happens only for guests created using xl, but it does not happen for
guests created using libvirt. I addressed that in the v5 patch. Please
see below for more details.

> Also, from the patch v5:
> > Changes in v5:
> >   * v4 worked only in the case of guests created using 'xl' command.
> >     Enhanced the fix to work for guests created using libvirt too.
> 
> I'm confused by the responses in the thread which relate to libvirt.
> ISTM that a libvirt patch is also required.  Do you mean that in v5
> there is also a libvirt patch ?

libvirt ends up calling do_domain_create() in tools/libxl/libxl_create.c,
and that is where I am registering the error handler. That change takes
care of guests created using xl command as well as libvirt. Hence there
is no change in libvirt.

Venu


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel