Re: [Xen-devel] [PATCH v2 02/17] arm64: vgic-v3: Add ICV_BPR1_EL1 handler

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 28/03/18 04:51, Manish Jaggi wrote:
> On 03/27/2018 05:08 PM, Marc Zyngier wrote:
> > On 27/03/18 12:27, Manish Jaggi wrote:
> > > On 03/27/2018 04:55 PM, Marc Zyngier wrote:
> > > > On 27/03/18 12:15, Manish Jaggi wrote:
> > > > > On 03/27/2018 04:41 PM, Marc Zyngier wrote:
> > > > > > On 27/03/18 12:07, Manish Jaggi wrote:
> > > > > > > On 03/27/2018 04:35 PM, Marc Zyngier wrote:
> > > > > > > > On 27/03/18 11:56, Manish Jaggi wrote:
> > > > > > > > > On 03/27/2018 04:15 PM, Marc Zyngier wrote:
> > > > > > > > > > On 27/03/18 11:35, Manish Jaggi wrote:
> > > > > > > > > > > On 03/27/2018 04:00 PM, Marc Zyngier wrote:
> > > > > > > > > > > > On 27/03/18 10:07, Manish Jaggi wrote:
> > > > > Will it be possible to review the remaining part of the code, so 
> > > > > that I
> > > > > can address
> > > > > other comments in v3 as well.
> > > > I suggest you wait until some other folks have a chance to properly
> > > > review the series. You only posted the stuff this morning, give them a
> > > > chance. A week between two versions is probably the right timing.
> > > Xen 4.11 window closes this week, so I have only few days.
I agree with Marc on giving a week between each version. 
Maintainers/reviewers have other duty and you can't expect them to 
review your series promptly. There are no difference with merge window 
closing.
Instead you should plan well in advance if you want to get your code in 
a specific release.
> > > I am hoping to get your ack before that.
> > My Ack is not the maintainers' (which you'd need anyway), and your
> > series is not the only one I need to review. I don't plan on having
> > another look at it this week anyway.
> >
> > As for the Xen deadline, I'm sure there will be another one.
> Hi Julien,
> Is it prudent to send v3 with the two changes of marc suggested in this 
> mail ?
> Since this is a errata workaround, and hopefully it should make it to 4.11.
> I have tried to address the v1 comments in v2, could you please have a 
> look at it.
You were probably aware from your management that I was traveling for 
the past 2 weeks. So the cut-off for any patches I needed to review for 
Xen 4.11 was right before my holidays (the week before easter).
Even if the code freeze was moved to end of this week, I am unlikely 
going to have time to fully review the series by then. You can still 
resend version while Xen is in code freeze, so this could be merge as 
soon as the tree re-open.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel