Re: [Xen-devel] [PATCH] x86/hvm/ioreq: fix out of bounds access in error path

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 04/04/18 12:11, Paul Durrant wrote:
>> -----Original Message-----
>> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
>> Sent: 04 April 2018 12:03
>> To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>;
>> Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Paul Durrant
>> <Paul.Durrant@xxxxxxxxxx>
>> Subject: [PATCH] x86/hvm/ioreq: fix out of bounds access in error path
>>
>> It is possible to call the error path with i pointing beyond the end
>> of the array.
>>
>> There is another bug that if there is already a default ioreq server,
>> the code will actually sets the element to NULL, hence leaking memory.
>>
>> Move setting NULL to where it is needed.
>>
>> Coverity-ID: 1433777
>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel