Re: [Xen-devel] [PATCH] python: xc: fix max_cpu_index sign error

[Wei Liu <wei.liu2@xxxxxxxxxx>]

CC Marek

On Thu, Apr 05, 2018 at 12:49:23PM +0000, Petre Eftime wrote:
> When 0-indexing, maximum index is num_entries - 1. The python xc library had a
> sign error where the minus was replaced by a plus, making tools that depended
> on it to look for CPUs that did not exist.
> 
> Signed-off-by: Petre Eftime <epetre@xxxxxxxxxx>
> ---
>  tools/python/xen/lowlevel/xc/xc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/python/xen/lowlevel/xc/xc.c 
> b/tools/python/xen/lowlevel/xc/xc.c
> index f501764..694bfa0 100644
> --- a/tools/python/xen/lowlevel/xc/xc.c
> +++ b/tools/python/xen/lowlevel/xc/xc.c
> @@ -1079,7 +1079,7 @@ static PyObject *pyxc_topologyinfo(XcObject *self)
>          }
>      }
>  
> -    ret_obj = Py_BuildValue("{s:i}", "max_cpu_index", num_cpus + 1);
> +    ret_obj = Py_BuildValue("{s:i}", "max_cpu_index", num_cpus - 1);
>  
>      PyDict_SetItemString(ret_obj, "cpu_to_core", cpu_to_core_obj);
>      Py_DECREF(cpu_to_core_obj);
> -- 
> 2.7.3.AMZN
> 
> 
> 
> 
> Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar 
> Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in 
> Romania. Registration number J22/2621/2005.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel