[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC





On 04/06/2018 10:26 AM, Julien Grall wrote:
(+Juergen)

Hi,

On 04/05/2018 11:16 AM, Amit Singh Tomar wrote:
This patch adds driver for UART controller found on Armada 3700 SoC.

There is no reference manuals available for 3700 SoC in public and it
is derived by looking at Linux driver[1].

[1]https://github.com/torvalds/linux/blob/master/drivers/tty/serial/mvebu-uart.c

Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
---
Changes since v2:
     * Addressed Andre's comments.
Changes since v1:
     * Addressed Wei Liu's comments
     * Addressed Andre's comments.
Changes since RFC:
     * Addressed Julien's comments.
---
  xen/drivers/char/Kconfig      |   8 ++
  xen/drivers/char/Makefile     |   1 +
  xen/drivers/char/mvebu-uart.c | 296 ++++++++++++++++++++++++++++++++++++++++++

As I said on the first version, I think this should fold under "ARM" as all the arch specific UART driver (PL011 & co).

I was expecting this patch to modify MAINTAINERS. I would be ok to commit like that but please send a patch to address this issue as soon as possible.

It sounds like there are confusion on what I requested here. AFAICT, the MVEBU driver is exclusively used by Arm. So this could be maintained by Stefano and I.

So we could add an entry for that file under "ARM (W/ VIRTUALIZATION EXTENSIONS) ARCHITECTURE" in MAINTAINERS file.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.