[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [ovmf bisection] complete build-amd64
branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c Bug not present: d22c995a481485d8240453a9e5ea9af1d87a4c80 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/122030/ commit 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c Author: Kinney, Michael D <michael.d.kinney@xxxxxxxxx> Date: Tue Apr 3 06:40:24 2018 +0800 MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls This patch fixes an issue with VlvTbltDevicePkg introduced by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926. The history is as below. To support heap guard feature, 14dde9e903bb9a719ebb8f3381da72b19509bc36 added support for SetMemorySpaceAttributes() to handle page attributes, but after that, a combination of CPU arch attributes and other attributes was not allowed anymore, for example, UC + RUNTIME. It is a regression. Then 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 was to fix the regression, and we thought 0 CPU arch attributes may be used to clear CPU arch attributes, so 0 CPU arch attributes was allowed to be sent to gCpu->SetMemoryAttributes(). But some implementation of CPU driver may return error for 0 CPU arch attributes. That fails the case that caller just calls SetMemorySpaceAttributes() with none CPU arch attributes (for example, RUNTIME), and the purpose of the case is not to clear CPU arch attributes. This patch filters the call to gCpu->SetMemoryAttributes() if the requested attributes is 0. It also removes the #define INVALID_CPU_ARCH_ATTRIBUTES that is no longer used. Cc: Heyi Guo <heyi.guo@xxxxxxxxxx> Cc: Yi Li <phoenix.liyi@xxxxxxxxxx> Cc: Renhao Liang <liangrenhao@xxxxxxxxxx> Cc: Star Zeng <star.zeng@xxxxxxxxx> Cc: Eric Dong <eric.dong@xxxxxxxxx> Cc: Liming Gao <liming.gao@xxxxxxxxx> Cc: Jian J Wang <jian.j.wang@xxxxxxxxx> Cc: Ruiyu Ni <ruiyu.ni@xxxxxxxxx> Signed-off-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx> Signed-off-by: Star Zeng <star.zeng@xxxxxxxxx> Contributed-under: TianoCore Contribution Agreement 1.1 Reviewed-by: Jiewen Yao <jiewen.yao@xxxxxxxxx> Reviewed-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx> For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64.xen-build --summary-out=tmp/122030.bisection-summary --basis-template=121769 --blessings=real,real-bisect ovmf build-amd64 xen-build Searching for failure / basis pass: 121977 fail [host=godello1] / 121769 [host=italia1] 121741 [host=godello0] 121710 [host=godello0] 121669 [host=elbling1] 121490 [host=italia1] 121374 ok. Failure / basis pass flights: 121977 / 121374 (tree with no url: minios) (tree with no url: seabios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf Basis pass 3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085-0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c git://xenbits.xen.org/qemu-xen-traditional.git#c8ea0457495342c417c3dc033bba25148b279f60-c8ea0457495342c417c3dc033bba25148b279f60 git://xenbits.xen.org/qemu-xen.git#5c3fdee026a204a59cb392e43a313ab558de9682-5c3fdee026a204a59cb392e43a313ab558de9682 git://xenbits.xen.org/xen.git#eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf-eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf Loaded 1001 nodes in revision graph Searching for test results: 121374 pass 3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 121372 [host=huxelrebe1] 121488 [host=italia1] 121490 [host=italia1] 121663 [host=huxelrebe1] 121669 [host=elbling1] 121741 [host=godello0] 121710 [host=godello0] 121769 [host=italia1] 121901 [host=godello0] 122022 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 121977 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122023 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122004 [host=godello0] 122024 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122006 pass 3d7ebd6434311f6cf7e9dbb42c9db0f6f3185085 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 121976 [host=godello0] 121993 [host=godello0] 121994 [host=godello0] 121995 [host=godello0] 122012 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 121999 [host=godello0] 122001 [host=godello0] 122026 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122015 pass de4f7f52f2003b854a754e3815f0a0c1c611118f c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122029 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122016 pass 00c5eede482104f0f92f988805a604655060fd35 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122018 pass 456c4ccab27b79f1b9c8d13ddcb5ed5453c09c53 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122030 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf 122020 pass 9686a4678de78e797e1368b9ff131890d3dee41b c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf Searching for interesting versions Result found: flight 121374 (pass), for basis pass Result found: flight 121977 (fail), for basis failure Repro found: flight 122006 (pass), for basis pass Repro found: flight 122012 (fail), for basis failure 0 revisions at d22c995a481485d8240453a9e5ea9af1d87a4c80 c8ea0457495342c417c3dc033bba25148b279f60 5c3fdee026a204a59cb392e43a313ab558de9682 eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf No revisions left to test, checking graph state. Result found: flight 122022 (pass), for last pass Result found: flight 122023 (fail), for first failure Repro found: flight 122024 (pass), for last pass Repro found: flight 122026 (fail), for first failure Repro found: flight 122029 (pass), for last pass Repro found: flight 122030 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c Bug not present: d22c995a481485d8240453a9e5ea9af1d87a4c80 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/122030/ commit 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c Author: Kinney, Michael D <michael.d.kinney@xxxxxxxxx> Date: Tue Apr 3 06:40:24 2018 +0800 MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls This patch fixes an issue with VlvTbltDevicePkg introduced by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926. The history is as below. To support heap guard feature, 14dde9e903bb9a719ebb8f3381da72b19509bc36 added support for SetMemorySpaceAttributes() to handle page attributes, but after that, a combination of CPU arch attributes and other attributes was not allowed anymore, for example, UC + RUNTIME. It is a regression. Then 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 was to fix the regression, and we thought 0 CPU arch attributes may be used to clear CPU arch attributes, so 0 CPU arch attributes was allowed to be sent to gCpu->SetMemoryAttributes(). But some implementation of CPU driver may return error for 0 CPU arch attributes. That fails the case that caller just calls SetMemorySpaceAttributes() with none CPU arch attributes (for example, RUNTIME), and the purpose of the case is not to clear CPU arch attributes. This patch filters the call to gCpu->SetMemoryAttributes() if the requested attributes is 0. It also removes the #define INVALID_CPU_ARCH_ATTRIBUTES that is no longer used. Cc: Heyi Guo <heyi.guo@xxxxxxxxxx> Cc: Yi Li <phoenix.liyi@xxxxxxxxxx> Cc: Renhao Liang <liangrenhao@xxxxxxxxxx> Cc: Star Zeng <star.zeng@xxxxxxxxx> Cc: Eric Dong <eric.dong@xxxxxxxxx> Cc: Liming Gao <liming.gao@xxxxxxxxx> Cc: Jian J Wang <jian.j.wang@xxxxxxxxx> Cc: Ruiyu Ni <ruiyu.ni@xxxxxxxxx> Signed-off-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx> Signed-off-by: Star Zeng <star.zeng@xxxxxxxxx> Contributed-under: TianoCore Contribution Agreement 1.1 Reviewed-by: Jiewen Yao <jiewen.yao@xxxxxxxxx> Reviewed-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx> Revision graph left in /home/logs/results/bisect/ovmf/build-amd64.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 122030: tolerable ALL FAIL flight 122030 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/122030/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64 6 xen-build fail baseline untested jobs: build-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |