[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [ovmf bisection] complete build-amd64-xsm



branch xen-unstable
xenbranch xen-unstable
job build-amd64-xsm
testid xen-build

Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Bug not present: d22c995a481485d8240453a9e5ea9af1d87a4c80
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/122069/


  commit 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Author: Kinney, Michael D <michael.d.kinney@xxxxxxxxx>
  Date:   Tue Apr 3 06:40:24 2018 +0800
  
      MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls
      
      This patch fixes an issue with VlvTbltDevicePkg introduced
      by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926.
      
      The history is as below.
      To support heap guard feature, 14dde9e903bb9a719ebb8f3381da72b19509bc36
      added support for SetMemorySpaceAttributes() to handle page attributes,
      but after that, a combination of CPU arch attributes and other attributes
      was not allowed anymore, for example, UC + RUNTIME. It is a regression.
      Then 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 was to fix the regression,
      and we thought 0 CPU arch attributes may be used to clear CPU arch
      attributes, so 0 CPU arch attributes was allowed to be sent to
      gCpu->SetMemoryAttributes().
      
      But some implementation of CPU driver may return error for 0 CPU arch
      attributes. That fails the case that caller just calls
      SetMemorySpaceAttributes() with none CPU arch attributes (for example,
      RUNTIME), and the purpose of the case is not to clear CPU arch attributes.
      
      This patch filters the call to gCpu->SetMemoryAttributes()
      if the requested attributes is 0.  It also removes the #define
      INVALID_CPU_ARCH_ATTRIBUTES that is no longer used.
      
      Cc: Heyi Guo <heyi.guo@xxxxxxxxxx>
      Cc: Yi Li <phoenix.liyi@xxxxxxxxxx>
      Cc: Renhao Liang <liangrenhao@xxxxxxxxxx>
      Cc: Star Zeng <star.zeng@xxxxxxxxx>
      Cc: Eric Dong <eric.dong@xxxxxxxxx>
      Cc: Liming Gao <liming.gao@xxxxxxxxx>
      Cc: Jian J Wang <jian.j.wang@xxxxxxxxx>
      Cc: Ruiyu Ni <ruiyu.ni@xxxxxxxxx>
      Signed-off-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx>
      Signed-off-by: Star Zeng <star.zeng@xxxxxxxxx>
      Contributed-under: TianoCore Contribution Agreement 1.1
      Reviewed-by: Jiewen Yao <jiewen.yao@xxxxxxxxx>
      Reviewed-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx>


For bisection revision-tuple graph see:
   
http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step 
--graph-out=/home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build 
--summary-out=tmp/122069.bisection-summary --basis-template=121769 
--blessings=real,real-bisect ovmf build-amd64-xsm xen-build
Searching for failure / basis pass:
 122057 fail [host=godello0] / 121769 ok.
Failure / basis pass flights: 122057 / 121769
(tree with no url: minios)
(tree with no url: seabios)
Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
451004603247205467ec34b366b4cfa3814a5d95
Basis pass aae02dccf5b0ad07e60d2738f350b3b39df389d7 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
Generating revisions with ./adhoc-revtuple-generator  
https://github.com/tianocore/edk2.git#aae02dccf5b0ad07e60d2738f350b3b39df389d7-0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
 
git://xenbits.xen.org/qemu-xen-traditional.git#c8ea0457495342c417c3dc033bba25148b279f60-c8ea0457495342c417c3dc033bba25148b279f60
 
git://xenbits.xen.org/qemu-xen.git#5c3fdee026a204a59cb392e43a313ab558de9682-5c3fdee026a204a59cb392e43a313ab558de9682
 
git://xenbits.xen.org/xen.git#eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf-451004603247205467ec34b366b4cfa3814a5d95
Loaded 2001 nodes in revision graph
Searching for test results:
 121769 pass aae02dccf5b0ad07e60d2738f350b3b39df389d7 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 121901 fail irrelevant
 121977 [host=godello1]
 122037 [host=godello1]
 122068 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122048 pass irrelevant
 122038 [host=godello1]
 122039 [host=godello1]
 122045 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
451004603247205467ec34b366b4cfa3814a5d95
 122040 [host=godello1]
 122055 pass aae02dccf5b0ad07e60d2738f350b3b39df389d7 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
3f8f12281dd20da62366f555cf13be0e87d68a91
 122007 fail irrelevant
 122031 [host=godello1]
 122050 pass irrelevant
 122032 [host=godello1]
 122041 [host=godello1]
 122033 [host=godello1]
 122064 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122035 [host=godello1]
 122052 pass aae02dccf5b0ad07e60d2738f350b3b39df389d7 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122058 pass fc504fdea7fe92bfa88e15f50e64b4d76d4f75fd 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122044 pass aae02dccf5b0ad07e60d2738f350b3b39df389d7 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
eabb83121226d5a6a5a68da3a913ac0b5bb1e0cf
 122059 pass f0053e837a2141e3c09ad376efe27fd17c522b04 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122046 fail irrelevant
 122053 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
451004603247205467ec34b366b4cfa3814a5d95
 122054 pass aae02dccf5b0ad07e60d2738f350b3b39df389d7 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
e5fe34fd23816601de17b0a428909c95acf01c93
 122051 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
451004603247205467ec34b366b4cfa3814a5d95
 122062 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122060 pass 9686a4678de78e797e1368b9ff131890d3dee41b 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122069 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122061 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
 122057 fail 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
451004603247205467ec34b366b4cfa3814a5d95
 122063 pass d22c995a481485d8240453a9e5ea9af1d87a4c80 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
Searching for interesting versions
 Result found: flight 121769 (pass), for basis pass
 Result found: flight 122045 (fail), for basis failure
 Repro found: flight 122052 (pass), for basis pass
 Repro found: flight 122053 (fail), for basis failure
 0 revisions at d22c995a481485d8240453a9e5ea9af1d87a4c80 
c8ea0457495342c417c3dc033bba25148b279f60 
5c3fdee026a204a59cb392e43a313ab558de9682 
9383de210e747f15d0fd10ade89e35d543fbc4e8
No revisions left to test, checking graph state.
 Result found: flight 122061 (pass), for last pass
 Result found: flight 122062 (fail), for first failure
 Repro found: flight 122063 (pass), for last pass
 Repro found: flight 122064 (fail), for first failure
 Repro found: flight 122068 (pass), for last pass
 Repro found: flight 122069 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Bug not present: d22c995a481485d8240453a9e5ea9af1d87a4c80
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/122069/


  commit 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c
  Author: Kinney, Michael D <michael.d.kinney@xxxxxxxxx>
  Date:   Tue Apr 3 06:40:24 2018 +0800
  
      MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls
      
      This patch fixes an issue with VlvTbltDevicePkg introduced
      by commit 5b91bf82c67b586b9588cbe4bbffa1588f6b5926.
      
      The history is as below.
      To support heap guard feature, 14dde9e903bb9a719ebb8f3381da72b19509bc36
      added support for SetMemorySpaceAttributes() to handle page attributes,
      but after that, a combination of CPU arch attributes and other attributes
      was not allowed anymore, for example, UC + RUNTIME. It is a regression.
      Then 5b91bf82c67b586b9588cbe4bbffa1588f6b5926 was to fix the regression,
      and we thought 0 CPU arch attributes may be used to clear CPU arch
      attributes, so 0 CPU arch attributes was allowed to be sent to
      gCpu->SetMemoryAttributes().
      
      But some implementation of CPU driver may return error for 0 CPU arch
      attributes. That fails the case that caller just calls
      SetMemorySpaceAttributes() with none CPU arch attributes (for example,
      RUNTIME), and the purpose of the case is not to clear CPU arch attributes.
      
      This patch filters the call to gCpu->SetMemoryAttributes()
      if the requested attributes is 0.  It also removes the #define
      INVALID_CPU_ARCH_ATTRIBUTES that is no longer used.
      
      Cc: Heyi Guo <heyi.guo@xxxxxxxxxx>
      Cc: Yi Li <phoenix.liyi@xxxxxxxxxx>
      Cc: Renhao Liang <liangrenhao@xxxxxxxxxx>
      Cc: Star Zeng <star.zeng@xxxxxxxxx>
      Cc: Eric Dong <eric.dong@xxxxxxxxx>
      Cc: Liming Gao <liming.gao@xxxxxxxxx>
      Cc: Jian J Wang <jian.j.wang@xxxxxxxxx>
      Cc: Ruiyu Ni <ruiyu.ni@xxxxxxxxx>
      Signed-off-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx>
      Signed-off-by: Star Zeng <star.zeng@xxxxxxxxx>
      Contributed-under: TianoCore Contribution Agreement 1.1
      Reviewed-by: Jiewen Yao <jiewen.yao@xxxxxxxxx>
      Reviewed-by: Michael D Kinney <michael.d.kinney@xxxxxxxxx>

Revision graph left in 
/home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
122069: tolerable ALL FAIL

flight 122069 ovmf real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/122069/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64-xsm               6 xen-build               fail baseline untested


jobs:
 build-amd64-xsm                                              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.