Re: [Xen-devel] [PATCH v8] new config option vtsc_tolerance_khz to avoid TSC emulation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.04.18 at 22:29, <olaf@xxxxxxxxx> wrote:
> @@ -34,7 +35,8 @@ int handle_tsc_info(struct xc_sr_context *ctx, struct 
> xc_sr_record *rec)
>      }
>  
>      if ( xc_domain_set_tsc_info(xch, ctx->domid, tsc->mode,
> -                                tsc->nsec, tsc->khz, tsc->incarnation) )
> +                                tsc->nsec, tsc->khz, tsc->vtsc_tolerance,
> +                                tsc->incarnation) )

Is there any guarantee that old hypervisors will send this field as zero
(rather than some random value)? If so, I think this should be said
explicitly in the commit message, together with the fact that you
re-use padding fields.

Hypervisor side provisionally (upon Andrew finding his prior
concerns addressed)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel