[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/5] for-linux/sndif: add explicit back and front synchronization

Hello, Konrad, Takashi!

Could you please review the *Linux Kernel* version of the changes?
As I said in the cover letter below there is no functional changes
comparing to the corresponding Xen version, but spaces to tabs.
Still, formally, I have to drop the R-b tags and request for the new review.

Thank you,

P.S. Minus GlobalLogic e-mails which bounce

On 04/12/2018 07:00 PM, Oleksandr Andrushchenko wrote:
Hello, all!

This is the syncup version of the sound protocol changes for
Linux Kernel with the only difference from the corresponding Xen
version being spaces to tabs conversion. Regradless of this only
change I have dropped R-b tags received for Xen version.

In order to provide explicit synchronization between backend and
frontend the following changes are introduced in the protocol:
  - bump protocol version to 2
  - add new ring buffer for sending asynchronous events from
    backend to frontend to report number of bytes played by the
    frontend (XENSND_EVT_CUR_POS)
  - introduce trigger events for playback control: start/stop/pause/resume
  - add "req-" prefix to event-channel and ring-ref to unify naming
    of the Xen event channels for requests and events
  - add XENSND_OP_HW_PARAM_QUERY request to read/update
    stream configuration space: request passes desired intervals/formats for
    the stream parameters and the response returns allowed intervals and
    formats mask that can be used.
  - MAJOR: changed req/resp/evt packet sizes from 32 to 64 octets
  -  Reworked XENSND_OP_HW_PARAM_QUERY so it now sends all
    parameters at once, allowing to check all the configuration
  - Minor documentation cleanup (added missed "reserved" fields)

Oleksandr Andrushchenko (5):
   xen/sndif: Introduce protocol version
   xen/sndif: Fix missed "reserved" fields in comments
   xen/sndif: Make requests and responses 64 octets long
   xen/sndif: Add explicit back and front synchronization
   xen/sndif: Add explicit back and front parameter negotiation

  include/xen/interface/io/sndif.h | 322 +++++++++++++++++++++++++++++--
  1 file changed, 306 insertions(+), 16 deletions(-)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.