Re: [Xen-devel] [PATCH 1/2] x86/microcode: Synchronize late microcode loading

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.04.18 at 07:25, <chao.gao@xxxxxxxxx> wrote:
> On Thu, Apr 12, 2018 at 09:29:34AM -0700, Raj, Ashok wrote:
>>On Fri, Mar 30, 2018 at 02:59:00PM +0800, Chao Gao wrote:
>>> From: Gao Chao <chao.gao@xxxxxxxxx>
>>> 
>>> This patch is to backport microcode improvement patches from linux
>>> kernel. Below are the original patches description:
>>> 
>>>     commit a5321aec6412b20b5ad15db2d6b916c05349dbff
>>>     Author: Ashok Raj <ashok.raj@xxxxxxxxx>
>>>     Date:   Wed Feb 28 11:28:46 2018 +0100
>>> 
>>>     x86/microcode: Synchronize late microcode loading
>>> 
>>>     Original idea by Ashok, completely rewritten by Borislav.
>>> 
>>>     Before you read any further: the early loading method is still the
>>>     preferred one and you should always do that. The following patch is
>>>     improving the late loading mechanism for long running jobs and cloud use
>>>     cases.
>>> 
>>>     Gather all cores and serialize the microcode update on them by doing it
>>>     one-by-one to make the late update process as reliable as possible and
>>>     avoid potential issues caused by the microcode update.
>>> 
>>>     [ Borislav: Rewrite completely. ]
>>> 
>>>     Co-developed-by: Borislav Petkov <bp@xxxxxxx>
>>>     Signed-off-by: Ashok Raj <ashok.raj@xxxxxxxxx>
>>>     Signed-off-by: Borislav Petkov <bp@xxxxxxx>
>>>     Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>>     Tested-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
>>>     Tested-by: Ashok Raj <ashok.raj@xxxxxxxxx>
>>
>>The tested by tags were good for linux upstream. Can you make sure
>>you add your name under tested-by for xen?
> 
> Tested-by doesn't mean they have tested this patch. I just put the
> original commits description here.

Tested-by being as meaningful in Xen as it is in Linux, retaining such tags 
(other
than authorship ones) is generally wrong, as it gives a wrong impression on
what testing the _Xen_ patch has seen.

> If Xen permits such tested-by from the sender and author, I will add one.

I think it is generally implied that the author has done some testing. In the
case here - with a ported over Linux commit by other than the original
author - I would view a T-b by the original author as meaningful though. It
should be made clear though that this is a ported Linux commit, which
generally we do by naming the Linux commit. See e.g. the history of
mwait-idle.c, where most of the commits are straight ports from Linux.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel