Re: [Xen-devel] [PATCH 2/8] x86/HVM/SVM: Add AVIC initialization code

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Apr 16, 2018 at 09:55:20AM -0600, Jan Beulich wrote:
> >>> On 04.04.18 at 01:01, <Janakarajan.Natarajan@xxxxxxx> wrote:
> > From: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> > +/*
> > + * Note: Current max index allowed for physical APIC ID table is 255.
> > + */
> 
> This is a single line comment.
> 
> > +#define AVIC_PHY_APIC_ID_MAX    0xFF
> 
> Is this really an AVIC-specific constant, rather than e.g.
> GET_xAPIC_ID(APIC_ID_MASK)?

Also, this is not the max APIC ID, max APIC ID would be 0xfe, 255 is
the APIC broadcast id. You cannot have a physical APIC with ID 255 in
xAPIC mode.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel