Re: [Xen-devel] [PATCH] shim: don't let build modify shim.config

[Juergen Gross <jgross@xxxxxxxx>]

On 19/04/18 12:47, Jan Beulich wrote:
>>>> On 19.04.18 at 12:30, <jgross@xxxxxxxx> wrote:
>> --- a/tools/firmware/xen-dir/Makefile
>> +++ b/tools/firmware/xen-dir/Makefile
>> @@ -41,21 +41,22 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
>>  $(D): linkfarm.stamp
>>      $(MAKE) -C $(D)/xen distclean
>>  
>> -.PHONY: shim-%config
>> -shim-%config: $(D) FORCE
>> -    $(MAKE) -C $(D)/xen $*config \
> 
> I think there was a reason for the % and $*.

The only one I could think of is the possibility to do

make shim-defaultconfig

or similar calls. Question is who will ever need that. In case it is
believed to be valuable I can keep it.

>> +xen-shim.config: shim.config
>> +    cp $< $@
> 
> Why not copy it to where it actually belong - xen/.config?

Hmm, true. In case nobody objects I'll do that.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel