Re: [Xen-devel] [PATCH v6] x86/setup: properly update PTEs if src/dst overlaps when relocating Xen image

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.04.18 at 11:15, <daniel.kiper@xxxxxxxxxx> wrote:
> On Thu, Apr 19, 2018 at 09:05:35AM -0600, Jan Beulich wrote:
>> >>> On 19.04.18 at 16:28, <daniel.kiper@xxxxxxxxxx> wrote:
>> > @@ -1019,6 +1020,15 @@ void __init noreturn __start_xen(unsigned long 
>> > mbi_p)
>> >              bootsym(trampoline_xen_phys_start) = e;
>> >
>> >              /*
>> > +             * All PTEs pointing above that address are not candidates for
>> > +             * relocation. Due to possibility of partial overlap of the 
>> > end
>> > +             * of source image and the beginning of region for destination
>> > +             * image some PTEs may point to addresses in
>> > +             * range [e, e + XEN_IMG_OFFSET).
>> > +             */
>> > +            pte_update_limit = PFN_DOWN(e + XEN_IMG_OFFSET);
>>
>> Perhaps better start with "No PTEs pointing above this address are
>> candidates ..."?
> 
> I am OK with that change. Should I post v7 or are you going to update
> the comment before committing? Both works for me.

I've recorded a note to that effect, but I certainly wouldn't mind if I didn't
have to edit the patch before committing.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel