Re: [Xen-devel] [PATCH 3/6] arm: make it possible to disable the SMMU driver

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.04.18 at 17:44, <julien.grall@xxxxxxx> wrote:
> On 18/04/18 23:15, Stefano Stabellini wrote:
>> --- a/xen/drivers/passthrough/Kconfig
>> +++ b/xen/drivers/passthrough/Kconfig
>> @@ -1,3 +1,5 @@
>>   
>>   config HAS_PASSTHROUGH
>>      bool
>> +
>> +source "drivers/passthrough/arm/Kconfig"
> 
> Can't we load arm/Kconfig only when arm is selected? This would avoid 
> weird option on x86.

How would those options appear for x86, given ...

>> --- /dev/null
>> +++ b/xen/drivers/passthrough/arm/Kconfig
>> @@ -0,0 +1,7 @@
>> +
>> +config HAS_SMMUv2
>> +    bool "ARM SMMUv2 driver"
>> +    default y
>> +    depends on ARM

... this "depends on"? Of course if more options are going to appear here,
wrapping the whole file in "if ARM" would be useful anyway, even if only
to limit redundancy.

Otoh, as voiced before in a different context, I'm not convinced we want
such single-option Kconfig files, i.e. in the case here the option may better
go directly into xen/drivers/passthrough/Kconfig. Splitting files when they
grow too large is an option anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel